Fix UUID support #2007
Merged
Fix UUID support #2007
+88
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Following issue #1986 , I was about to make a smaller PR without the knowledge of the extra spark-related complications. In case it's useful, the only extra thing I had that you haven't (yet) added is a small unit test in tests/io/test_pyarrow_visitor.py at roughly line 235: |
|
Going down the rabbit hole, I'm able to reproduce this on the Java main branch: |
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Jun 16, 2025
While fixing some issues on the PyIceberg ends to fully support UUIDs: apache/iceberg-python#2007 I noticed this issue, and was suprised since UUID used to work with Spark, but it turns out that the dictionary encoded UUID was not implemented yet. For PyIceberg we only generate little data, so therefore this wasn't caught previously.
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Jun 16, 2025
While fixing some issues on the PyIceberg ends to fully support UUIDs: apache/iceberg-python#2007 I noticed this issue, and was suprised since UUID used to work with Spark, but it turns out that the dictionary encoded UUID was not implemented yet. For PyIceberg we only generate little data, so therefore this wasn't caught previously.
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Jun 16, 2025
While fixing some issues on the PyIceberg ends to fully support UUIDs: apache/iceberg-python#2007 I noticed this issue, and was suprised since UUID used to work with Spark, but it turns out that the dictionary encoded UUID was not implemented yet. For PyIceberg we only generate little data, so therefore this wasn't caught previously.
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Jun 16, 2025
While fixing some issues on the PyIceberg ends to fully support UUIDs: apache/iceberg-python#2007 I noticed this issue, and was suprised since UUID used to work with Spark, but it turns out that the dictionary encoded UUID was not implemented yet. For PyIceberg we only generate little data, so therefore this wasn't caught previously.
|
Thanks @kevinjqliu |
Fokko
added a commit
to apache/iceberg
that referenced
this pull request
Jul 9, 2025
* Spark: Support Parquet dictionary encoded UUIDs While fixing some issues on the PyIceberg ends to fully support UUIDs: apache/iceberg-python#2007 I noticed this issue, and was suprised since UUID used to work with Spark, but it turns out that the dictionary encoded UUID was not implemented yet. For PyIceberg we only generate little data, so therefore this wasn't caught previously. * Add another test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The UUID support is a gift that keeps on giving. The current support of PyIceberg is incomplete, and problematic. Mostly because:
I think we have to wait for some fixes in Arrow upstream until we can fully support this. In PyIceberg, we're converting the
fixed[16]to aUUID, but Spark does seem to error because the logical type annotation in Parquet is missing:Are these changes tested?
Are there any user-facing changes?
Closes #1986
Closes #2002